Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: call MenuHandlers without reflection #983

Closed
wants to merge 35 commits into from
Closed

refactor: call MenuHandlers without reflection #983

wants to merge 35 commits into from

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Mar 16, 2024 •
edited
Loading

refactor MainWindowMenuHandler and MainWindowMenu not to use reflection to invoke action. Otherwise, we use Action interface appeared in Java 1.6.
OmegaT project have not used it, because lib-mnemonics does not support Action interface in previous versions.
Now lib-mnemonics library version 1.2 adds AbstractmnemonicsAction class that help application define Acton with mnemonics.

Pull request type

  • Other (describe below)
    refactor

Which ticket is resolved?

dev-ML https://sourceforge.net/p/omegat/mailman/message/58749145/

What does this PR change?

  • Replace MainWindowMenuHandler#braBrabrahActionperformed method with Action classes that extends with AbstractMnemonicAction class
  • Change BaseMainWindowMenu to use Action class to construct UI components.
  • Deprecated IMainMenu#invokeAction but calls Action in action class.

Other information

Implementation depends on lib-mnemonics enhancement

omegat-org/lib-mnemonics#8

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@miurahr miurahr mentioned this pull request Mar 20, 2024
Closed
@miurahr miurahr marked this pull request as ready for review May 3, 2024 05:27
@miurahr miurahr force-pushed the topic/miurahr/gui/main/menu-construct-with-properties-abstract-action branch from d0ed739 to e4248fe Compare May 3, 2024 08:35
@miurahr
Copy link
Member Author

miurahr commented May 3, 2024

rebased on current master.

@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@miurahr miurahr force-pushed the topic/miurahr/gui/main/menu-construct-with-properties-abstract-action branch from cb48713 to 80bf094 Compare May 3, 2024 09:20
@miurahr
Copy link
Member Author

miurahr commented May 3, 2024

Now ready for merge.

@miurahr
feat: MenuHanlder actions with AbstractAction
65a7db0 
- refactor exit actions menus

Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr miurahr force-pushed the topic/miurahr/gui/main/menu-construct-with-properties-abstract-action branch from 09ebd74 to 65a7db0 Compare May 25, 2024 00:51
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@miurahr miurahr added this to the 6.1.0 (Require Java 11) milestone May 25, 2024
miurahr added 2 commits May 25, 2024 09:58
@miurahr
wip
db5820c 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
refactor: AccessTools constructor
5021ff7 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr miurahr changed the title reafactor: use AbstractMnemonicsAction to define Menu handlers refactor: use AbstractMnemonicsAction to define Menu handlers May 25, 2024
@miurahr miurahr changed the title refactor: use AbstractMnemonicsAction to define Menu handlers refactor: define Menu handlers with Swing Action interface May 25, 2024
miurahr added 3 commits May 25, 2024 11:19
@miurahr
refactor: IMainMenu#invokeAction
b067c1b 
- set default implementation of invokeAction interface
  with nothing
- Remove deprecated method from test overrides

Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
refactor: Log menu selection for debug
89692d0 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
refactor: invokeAction to invoke Action object
c9ca4b1 
Signed-off-by: Hiroshi Miura <[email protected]>
@github-actions GitHub Actions
Copy link

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/bifb6dizkwxoi

@miurahr miurahr marked this pull request as draft May 25, 2024 05:17
@miurahr miurahr force-pushed the topic/miurahr/gui/main/menu-construct-with-properties-abstract-action branch from 74ac6c6 to cb53607 Compare May 25, 2024 06:12
@github-actions GitHub Actions
Copy link

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/xmj7gndd4cum2

@miurahr
fix: logging component names
0f0b835 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr miurahr marked this pull request as ready for review May 28, 2024 21:22
miurahr added 7 commits May 29, 2024 07:31
@miurahr
style: menu action logging in single line
4f7b238 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
fix: action command str equals field name for shortcut key assign
e9d2ae0 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
feat: set shortcut key to Action object
3bab572 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
fix: drop action listener in BaseMainWindowMenu
d05b66b 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
fix: NPE and refactor
63decb6 
- Fix NPE: call parent frame in initalization
- move Handler common method to ProjectUICommands

Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
fix: duplicated UI component initialization
9e78061 
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr
refactor: import actions sub classes
a12a52c 
Signed-off-by: Hiroshi Miura <[email protected]>
@github-actions GitHub Actions
Copy link

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/n3374345rdyse

@github-actions GitHub Actions
Copy link

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/uogbpjfkry3ay

@github-actions GitHub Actions
Copy link

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/qeyigm5swrthi

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/2tp3fehqcl4kg

@miurahr
revert other text area changes
9c535fc 
Signed-off-by: Hiroshi Miura <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/l5yec62s2opoo

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/l5mfywxdoscps

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/vyvcdjwq4uisg

@miurahr
revert SearchWindowMenu chages
ffe1c3d 
Signed-off-by: Hiroshi Miura <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/ii7pv3pkrhgvm

@miurahr miurahr changed the title refactor: define Menu handlers with Swing Action interface refactor: call MenuHandlers without reflection Jun 10, 2024
@miurahr miurahr closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
6.1.0 (Require Java 11)
Development

Successfully merging this pull request may close these issues.
1 participant
@miurahr